diff options
author | Sebastiaan van Stijn <github@gone.nl> | 2022-05-31 17:01:43 +0200 |
---|---|---|
committer | Sebastiaan van Stijn <github@gone.nl> | 2022-05-31 21:53:38 +0200 |
commit | 553b0edb4c44bdddfad36524ba2b39c8c3b58ddd (patch) | |
tree | 0940896e2aa8fe5df833114ae3cbcb79f7f1cf71 /pkg | |
parent | ceefa7c7ffad6a602e797a2cb0c4bbaacdd46118 (diff) |
fix unclosed file-handles in tests
These seemed to prevent cleaning up directories;
On arm64:
=== RUN TestSysctlOverride
testing.go:1090: TempDir RemoveAll cleanup: unlinkat /tmp/TestSysctlOverride2860094781/001/mounts/shm: device or resource busy
--- FAIL: TestSysctlOverride (0.00s)
On Windows:
=== Failed
=== FAIL: github.com/docker/docker/daemon TestLoadOrCreateTrustKeyInvalidKeyFile (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestLoadOrCreateTrustKeyInvalidKeyFile2014634395\001\keyfile4156691647: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/daemon/graphdriver TestIsEmptyDir (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestIsEmptyDir1962964337\001\dir-with-empty-file\file2523853824: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/pkg/directory TestSizeEmptyFile (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSizeEmptyFile1562416712\001\file16507846: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/pkg/directory TestSizeNonemptyFile (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSizeNonemptyFile1240832785\001\file3265662846: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/pkg/directory TestSizeFileAndNestedDirectoryEmpty (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSizeFileAndNestedDirectoryEmpty2163416550\001\file3715413181: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/pkg/directory TestSizeFileAndNestedDirectoryNonempty (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSizeFileAndNestedDirectoryNonempty878205470\001\file3280422273: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/volume/service TestSetGetMeta (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSetGetMeta3332268057\001\db: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/volume/service TestList (0.03s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestList2846947953\001\volumes\metadata.db: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/volume/service TestRestore (0.02s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestRestore3368254142\001\volumes\metadata.db: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/daemon/graphdriver TestIsEmptyDir (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestIsEmptyDir2823795693\001\dir-with-empty-file\file2625561089: The process cannot access the file because it is being used by another process.
=== FAIL: github.com/docker/docker/pkg/directory TestSizeFileAndNestedDirectoryNonempty (0.00s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\CONTAI~1\AppData\Local\Temp\TestSizeFileAndNestedDirectoryNonempty4246252950\001\nested3442260313\file21164327: The process cannot access the file because it is being used by another process.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Diffstat (limited to 'pkg')
-rw-r--r-- | pkg/directory/directory_test.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/pkg/directory/directory_test.go b/pkg/directory/directory_test.go index 8477a202fe..ec9c97e699 100644 --- a/pkg/directory/directory_test.go +++ b/pkg/directory/directory_test.go @@ -35,6 +35,7 @@ func TestSizeEmptyFile(t *testing.T) { if file, err = os.CreateTemp(dir, "file"); err != nil { t.Fatalf("failed to create file: %s", err) } + defer file.Close() var size int64 if size, _ = Size(context.Background(), file.Name()); size != 0 { @@ -54,6 +55,7 @@ func TestSizeNonemptyFile(t *testing.T) { if file, err = os.CreateTemp(dir, "file"); err != nil { t.Fatalf("failed to create file: %s", err) } + defer file.Close() d := []byte{97, 98, 99, 100, 101} file.Write(d) @@ -96,6 +98,7 @@ func TestSizeFileAndNestedDirectoryEmpty(t *testing.T) { if file, err = os.CreateTemp(dir, "file"); err != nil { t.Fatalf("failed to create file: %s", err) } + defer file.Close() d := []byte{100, 111, 99, 107, 101, 114} file.Write(d) @@ -121,6 +124,7 @@ func TestSizeFileAndNestedDirectoryNonempty(t *testing.T) { if file, err = os.CreateTemp(dir, "file"); err != nil { t.Fatalf("failed to create file: %s", err) } + defer file.Close() data := []byte{100, 111, 99, 107, 101, 114} file.Write(data) @@ -129,6 +133,7 @@ func TestSizeFileAndNestedDirectoryNonempty(t *testing.T) { if nestedFile, err = os.CreateTemp(dirNested, "file"); err != nil { t.Fatalf("failed to create file in nested directory: %s", err) } + defer nestedFile.Close() nestedData := []byte{100, 111, 99, 107, 101, 114} nestedFile.Write(nestedData) |